Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Psalm to PHPStan #155

Merged
merged 12 commits into from
Jan 14, 2025
Merged

Replace Psalm to PHPStan #155

merged 12 commits into from
Jan 14, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 8, 2025

No description provided.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (5dd5c6a) to head (954c48f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage     98.48%   98.48%           
  Complexity      263      263           
=========================================
  Files            10       10           
  Lines           660      660           
=========================================
  Hits            650      650           
  Misses           10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:under development Someone is working on a pull request. label Jan 8, 2025
* @psalm-import-type CssString from AssetManager
* @psalm-import-type JsFile from AssetManager
* @psalm-import-type JsString from AssetManager
* @phpstan-import-type CssFile from AssetManager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to change it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should keep Psalm annotations? PHPStan can read it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine either way. Just too many changes for no particular practical gain.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep psalm annotations, it can be useful to users who use psalm.

src/AssetBundle.php Outdated Show resolved Hide resolved
src/AssetConverter.php Outdated Show resolved Hide resolved
@vjik vjik marked this pull request as ready for review January 12, 2025 11:14
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Jan 12, 2025
@vjik vjik requested review from samdark and a team January 12, 2025 11:14
@@ -11,8 +11,7 @@
[![Build status](https://github.com/yiisoft/assets/actions/workflows/build.yml/badge.svg)](https://github.com/yiisoft/assets/actions/workflows/build.yml)
[![Code Coverage](https://codecov.io/gh/yiisoft/assets/graph/badge.svg?token=U09s7jclX6)](https://codecov.io/gh/yiisoft/assets)
[![Mutation testing badge](https://img.shields.io/endpoint?style=flat&url=https%3A%2F%2Fbadge-api.stryker-mutator.io%2Fgithub.com%2Fyiisoft%2Fassets%2Fmaster)](https://dashboard.stryker-mutator.io/reports/github.com/yiisoft/assets/master)
[![static analysis](https://github.com/yiisoft/assets/workflows/static%20analysis/badge.svg)](https://github.com/yiisoft/assets/actions?query=workflow%3A%22static+analysis%22)
[![type-coverage](https://shepherd.dev/github/yiisoft/assets/coverage.svg)](https://shepherd.dev/github/yiisoft/assets)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it missing with phpstan?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't found shepherd analog for PHPStan.

src/AssetUtil.php Show resolved Hide resolved
@vjik vjik merged commit cd1986e into master Jan 14, 2025
16 of 17 checks passed
@vjik vjik deleted the psalm-to-phpstan branch January 14, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants